Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 23 Mar 2012 23:11:33 +0000 (UTC)
From: "Brandon Li (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <805629444.11225.1332544293388.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <575853025.6229.1332467302167.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-3131) Improve TestStorageRestore
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Li updated HDFS-3131:
-----------------------------

    Release Note: added test case to make sure that restore failure doesn't stop checkpoint process
          Status: Patch Available  (was: Open)
    
> Improve TestStorageRestore
> --------------------------
>
>                 Key: HDFS-3131
>                 URL: https://issues.apache.org/jira/browse/HDFS-3131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.24.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Brandon Li
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-3131.patch
>
>
> Aaron has the following comments on TestStorageRestore in HDFS-3127.
> # removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
> # numStorageDirs can be made static
> # Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
> # Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
> # Some lines are over 80 chars.
> # No need for the numDatanodes variable - it's only used in one place.
> # Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira