Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BB2A9D64 for ; Fri, 9 Mar 2012 21:49:21 +0000 (UTC) Received: (qmail 15122 invoked by uid 500); 9 Mar 2012 21:49:20 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 15069 invoked by uid 500); 9 Mar 2012 21:49:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 15052 invoked by uid 99); 9 Mar 2012 21:49:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2012 21:49:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2012 21:49:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 70F5F1688F for ; Fri, 9 Mar 2012 21:48:57 +0000 (UTC) Date: Fri, 9 Mar 2012 21:48:57 +0000 (UTC) From: "Colin Patrick McCabe (Updated) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <498978047.45743.1331329737464.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1912001153.44780.1331319418749.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-3073) NetworkTopology::getLeaf should check for invalid topologies MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Patrick McCabe updated HDFS-3073: --------------------------------------- Attachment: HDFS-3073.002.patch * refactor getLeaf a bit * the exception getLeaf() throws for an invalid Node now includes the offending Node as a string, and a helpful error message. > NetworkTopology::getLeaf should check for invalid topologies > ------------------------------------------------------------ > > Key: HDFS-3073 > URL: https://issues.apache.org/jira/browse/HDFS-3073 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 1.0.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-3073.002.patch > > > Currently, NetworkTopology::getLeaf doesn't do too much validation on the NetworkTopology object itself. This results in us getting ClassCastException sometimes when the topology is invalid. We should have a less confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira