Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 20 Mar 2012 09:07:39 +0000 (UTC)
From: "Olivier Sallou (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1768955615.35798.1332234459070.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <752819439.35733.1332233498674.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-3118) wiki and hadoop templates provides
 wrong superusergroup property instead of supergroup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/HDFS-3118?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Sallou updated HDFS-3118:
---------------------------------

    Status: Patch Available  (was: Open)

--- src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java.orig=
=092012-03-20 09:54:33.000000000 +0100
+++ src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java=09201=
2-03-20 09:55:13.000000000 +0100
@@ -473,7 +473,7 @@
     fsOwner =3D UserGroupInformation.getCurrentUser();
     LOG.info("fsOwner=3D" + fsOwner);
=20
-    this.supergroup =3D conf.get("dfs.permissions.supergroup", "supergroup=
");
+    this.supergroup =3D conf.get(DFSConfigKeys.DFS_PERMISSIONS_SUPERUSERGR=
OUP_KEY, "supergroup");
     this.isPermissionEnabled =3D conf.getBoolean("dfs.permissions", true);
     LOG.info("supergroup=3D" + supergroup);
     LOG.info("isPermissionEnabled=3D" + isPermissionEnabled);
--- src/test/org/apache/hadoop/mapred/TestMapredSystemDir.java.orig=092012-=
03-20 09:56:37.000000000 +0100
+++ src/test/org/apache/hadoop/mapred/TestMapredSystemDir.java=092012-03-20=
 09:58:14.000000000 +0100
@@ -30,6 +30,7 @@
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.security.*;
+import org.apache.hadoop.hdfs.DFSConfigKeys;
=20
 /**
  * Test if JobTracker is resilient to garbage in mapred.system.dir.
@@ -49,7 +50,7 @@
     MiniMRCluster mr =3D null;
     try {
       // start dfs
-      conf.set("dfs.permissions.supergroup", "supergroup");
+      conf.set(DFSConfigKeys.DFS_PERMISSIONS_SUPERUSERGROUP_KEY, "supergro=
up");
       conf.set("mapred.system.dir", "/mapred");
       dfs =3D new MiniDFSCluster(conf, 1, true, null);
       FileSystem fs =3D dfs.getFileSystem();
@@ -120,4 +121,4 @@
       if (mr !=3D null) { mr.shutdown();}
     }
   }
-}
\ No newline at end of file
+}

--- src/hdfs/hdfs-default.xml.orig=092012-03-20 10:00:53.000000000 +0100
+++ src/hdfs/hdfs-default.xml=092012-03-20 10:01:04.000000000 +0100
@@ -184,7 +184,7 @@
 </property>
=20
 <property>
-  <name>dfs.permissions.supergroup</name>
+  <name>dfs.permissions.superusergroup</name>
   <value>supergroup</value>
   <description>The name of the group of super-users.</description>
 </property>
--- src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml.ori=
g=092012-03-20 10:02:01.000000000 +0100
+++ src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml=092=
012-03-20 10:02:14.000000000 +0100
@@ -227,7 +227,7 @@
 =09=09only those things visible using "other" permissions. Additional grou=
ps may be added to the comma-separated list.
     </li>
    =20
-=09<li><code>dfs.permissions.supergroup =3D supergroup</code>
+=09<li><code>dfs.permissions.superusergroup =3D supergroup</code>
 =09<br />The name of the group of super-users.
 =09</li>

--- src/docs/cn/src/documentation/content/xdocs/hdfs_permissions_guide.xml.=
orig=092012-03-20 10:03:17.000000000 +0100
+++ src/docs/cn/src/documentation/content/xdocs/hdfs_permissions_guide.xml=
=092012-03-20 10:03:30.000000000 +0100
@@ -170,7 +170,7 @@
 =09<dd>
 =09Web=E6=9C=8D=E5=8A=A1=E5=99=A8=E4=BD=BF=E7=94=A8=E7=9A=84=E7=94=A8=E6=
=88=B7=E5=90=8D=E3=80=82=E5=A6=82=E6=9E=9C=E5=B0=86=E8=BF=99=E4=B8=AA=E5=8F=
=82=E6=95=B0=E8=AE=BE=E7=BD=AE=E4=B8=BA=E8=B6=85=E7=BA=A7=E7=94=A8=E6=88=B7=
=E7=9A=84=E5=90=8D=E7=A7=B0=EF=BC=8C=E5=88=99=E6=89=80=E6=9C=89Web=E5=AE=A2=
=E6=88=B7=E5=B0=B1=E5=8F=AF=E4=BB=A5=E7=9C=8B=E5=88=B0=E6=89=80=E6=9C=89=E7=
=9A=84=E4=BF=A1=E6=81=AF=E3=80=82=E5=A6=82=E6=9E=9C=E5=B0=86=E8=BF=99=E4=B8=
=AA=E5=8F=82=E6=95=B0=E8=AE=BE=E7=BD=AE=E4=B8=BA=E4=B8=80=E4=B8=AA=E4=B8=8D=
=E4=BD=BF=E7=94=A8=E7=9A=84=E7=94=A8=E6=88=B7=EF=BC=8C=E5=88=99Web=E5=AE=A2=
=E6=88=B7=E5=B0=B1=E5=8F=AA=E8=83=BD=E8=AE=BF=E9=97=AE=E5=88=B0=E2=80=9Coth=
er=E2=80=9D=E6=9D=83=E9=99=90=E5=8F=AF=E8=AE=BF=E9=97=AE=E7=9A=84=E8=B5=84=
=E6=BA=90=E4=BA=86=E3=80=82=E9=A2=9D=E5=A4=96=E7=9A=84=E7=BB=84=E5=8F=AF=E4=
=BB=A5=E5=8A=A0=E5=9C=A8=E5=90=8E=E9=9D=A2=EF=BC=8C=E5=BD=A2=E6=88=90=E4=B8=
=80=E4=B8=AA=E7=94=A8=E9=80=97=E5=8F=B7=E5=88=86=E9=9A=94=E7=9A=84=E5=88=97=
=E8=A1=A8=E3=80=82
 =09</dd>
-=09<dt><code>dfs.permissions.supergroup =3D supergroup</code></dt>
+=09<dt><code>dfs.permissions.superusergroup =3D supergroup</code></dt>
 =09<dd>
 =09=E8=B6=85=E7=BA=A7=E7=94=A8=E6=88=B7=E7=9A=84=E7=BB=84=E5=90=8D=E3=80=
=82
 =09</dd>

               =20
> wiki and hadoop templates provides wrong superusergroup property instead =
of supergroup
> -------------------------------------------------------------------------=
-------------
>
>                 Key: HDFS-3118
>                 URL: https://issues.apache.org/jira/browse/HDFS-3118
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.0.0
>         Environment: Used Debian package install
>            Reporter: Olivier Sallou
>            Priority: Minor
>
> The hdfs-site template and the wiki: http://hadoop.apache.org/hdfs/docs/c=
urrent/hdfs_permissions_guide.html#The+Super-User
> refers to property dfs.permissions.superusergroup to define the group of =
superuser.
> However we must use the property dfs.permissions.supergroup, and not supe=
rusergroup, to make it work.
> In file src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java=
, supergroup is extracted from:
> this.supergroup =3D conf.get("dfs.permissions.supergroup", "supergroup");
> It does not make use of DFS_PERMISSIONS_SUPERUSERGROUP_KEY

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira