Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8CD8D9C84 for ; Thu, 22 Mar 2012 20:00:44 +0000 (UTC) Received: (qmail 38476 invoked by uid 500); 22 Mar 2012 20:00:44 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 38436 invoked by uid 500); 22 Mar 2012 20:00:44 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 38426 invoked by uid 99); 22 Mar 2012 20:00:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 20:00:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 20:00:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5BD55340F78 for ; Thu, 22 Mar 2012 20:00:23 +0000 (UTC) Date: Thu, 22 Mar 2012 20:00:23 +0000 (UTC) From: "Colin Patrick McCabe (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1763887857.4206.1332446423378.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2093459863.23914.1330984557352.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235958#comment-13235958 ] Colin Patrick McCabe commented on HDFS-3050: -------------------------------------------- also, I moved the xml utility function into a class in HDFS in the latest patch > refactor OEV to share more code with the NameNode > ------------------------------------------------- > > Key: HDFS-3050 > URL: https://issues.apache.org/jira/browse/HDFS-3050 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-3050.006.patch, HDFS-3050.007.patch, HDFS-3050.008.patch, HDFS-3050.009.patch > > > Current, OEV (the offline edits viewer) re-implements all of the opcode parsing logic found in the NameNode. This duplicated code creates a maintenance burden for us. > OEV should be refactored to simply use the normal EditLog parsing code, rather than rolling its own. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira