Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 26 Mar 2012 19:40:28 +0000 (UTC)
From: "Uma Maheswara Rao G (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1215406794.19014.1332790828357.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <976430818.10453.1331688278126.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3089) Move FSDatasetInterface and other
 related classes/interfaces to a package
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238723#comment-13238723 ] 

Uma Maheswara Rao G commented on HDFS-3089:
-------------------------------------------

Hi Nicholas,
 I have reviewed h3089_20120321b.patch.
 Patch mostly looks good. A few minor comments.

 1) looks you have removed dfs.datanode.block.volume.choice.policy config item from hdfs-default.xml
   may need to update with correct package name right? if there is a reason for removal or some other discussion  about it, could you please explain?. If we really want to remove the default config item, this JIRA may not be the correct place right?

 2) In my opinion, we may need to maintain the consistency of the class Names
   {code}
   public class FSDataset implements FsDatasetSpi<FSDataset.FSVolume> {
   {code}
  
  Many places we are reffering FileSystem as FS ----> ex: FSnamesystem, FSDataset.
  Now we named the SPI with small 's'.


Thanks
Uma

                
> Move FSDatasetInterface and other related classes/interfaces to a package
> -------------------------------------------------------------------------
>
>                 Key: HDFS-3089
>                 URL: https://issues.apache.org/jira/browse/HDFS-3089
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h3089_20120316_svn_mv.patch, h3089_20120319.patch, h3089_20120319_svn_mv.patch, h3089_20120321.patch, h3089_20120321b.patch, h3089_20120321b_svn_mv.patch, svn_mv.sh
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira