Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 5 Mar 2012 16:23:57 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1002171097.22772.1330964637350.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <918394441.38659.1324547310663.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2717) BookKeeper Journal output stream
 doesn't check addComplete rc
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222432#comment-13222432 ] 

Hadoop QA commented on HDFS-2717:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517091/HDFS-2717.2.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1951//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1951//console

This message is automatically generated.
                
> BookKeeper Journal output stream doesn't check addComplete rc
> -------------------------------------------------------------
>
>                 Key: HDFS-2717
>                 URL: https://issues.apache.org/jira/browse/HDFS-2717
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2717.2.diff, HDFS-2717.diff
>
>
> As summary says, we're not checking the addComplete return code, so there's a change of losing update. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira