hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Date Fri, 23 Mar 2012 18:03:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236858#comment-13236858
] 

Todd Lipcon commented on HDFS-3132:
-----------------------------------

bq. Please avoid cross-project patches and split the patches into sub-projects. Or, you have
to run all the checks and tests before committing

There's not currently any easy way to run all the checks. And the problem with splitting into
sub-projects is that, often, a patch in Common would actually break the build if it were committed
before the associated patch in HDFS. I'd rather chance introducing a few warnings than break
the build for everyone.

Regarding these particular patches, I originally put all of the code for HA in HDFS, but others
argued we should try to build a generic framework (despite the fact that HDFS is the only
implementer of all of these new Common pieces). So now we're left in this situation where
any non-trivial changes to failover have to go cross-project.

bq.  I guess you don't want to be known for adding findbugs or other warnings to Hadoop. 

Somehow I don't think that's what I'm known for... out of the 20+ things I've committed in
the last month, a mistake rate of 5% doesn't seem so bad.

Hopefully someone can spend some time working on cross-project test-patch which would ameliorate
this issue.
                
> Findbugs warning on HDFS trunk
> ------------------------------
>
>                 Key: HDFS-3132
>                 URL: https://issues.apache.org/jira/browse/HDFS-3132
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.24.0, 0.23.3
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state;
locked 50% of time". I think this was probably one of my recent cross-project HA patches in
which the QA bot was unable to run. Will investigate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message