hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-3131) Improve TestStorageRestore
Date Fri, 23 Mar 2012 01:48:22 GMT
Improve TestStorageRestore
--------------------------

                 Key: HDFS-3131
                 URL: https://issues.apache.org/jira/browse/HDFS-3131
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Tsz Wo (Nicholas), SZE
            Priority: Minor


Aaron has the following comments on TestStorageRestore in HDFS-3127.

# removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
# numStorageDirs can be made static
# Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
# Please put the contents of the test in a try/finally, with the calls to shutdown the cluster
and the 2NN in the finally block.
# Some lines are over 80 chars.
# No need for the numDatanodes variable - it's only used in one place.
# Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message