hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3050) refactor OEV to share more code with the NameNode
Date Tue, 06 Mar 2012 22:49:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223754#comment-13223754
] 

Aaron T. Myers commented on HDFS-3050:
--------------------------------------

Hey Nicholas, I see your point - in some sense it makes sense to stick all the OEV output
stuff in one class. On the other hand, however, doing what you describe would likely require
either making a bunch of the fields of these classes public, or adding accessors for all these
fields, just so this separate hypothetical OevUtil class can output them as XML. It seems
to me that these classes should be responsible for outputting themselves as XML, much as we
implement toString() right within the class.

Thoughts? I don't feel super strongly about this, it's just not obvious to me that your suggestion
is necessarily superior to how Colin has implemented it in this patch.
                
> refactor OEV to share more code with the NameNode
> -------------------------------------------------
>
>                 Key: HDFS-3050
>                 URL: https://issues.apache.org/jira/browse/HDFS-3050
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3050.patch2
>
>
> Current, OEV (the offline edits viewer) re-implements all of the opcode parsing logic
found in the NameNode.  This duplicated code creates a maintenance burden for us.
> OEV should be refactored to simply use the normal EditLog parsing code, rather than rolling
its own.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message