hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3025) Automatic log sync shouldn't happen inside logEdit path
Date Thu, 01 Mar 2012 01:05:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219693#comment-13219693
] 

Hadoop QA commented on HDFS-3025:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516620/hdfs-3025.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1931//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1931//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1931//console

This message is automatically generated.
                
> Automatic log sync shouldn't happen inside logEdit path
> -------------------------------------------------------
>
>                 Key: HDFS-3025
>                 URL: https://issues.apache.org/jira/browse/HDFS-3025
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node, performance
>    Affects Versions: 0.23.3
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-3025.txt, hdfs-3025.txt
>
>
> HDFS-3020 fixes the "automatic log sync" functionality so that, when logEdits is called
without log sync, it eventually triggers a sync. That sync ends up being inline, though, which
means the FSN lock is usually held during it. This causes a bunch of threads to pile up.
> Instead, we should have it just set a "syncNeeded" flag and trigger a sync from another
thread which isn't holding the lock (or from the same thread using a "logSyncIfNeeded" call).
> (credit to the FB branch for this idea)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message