hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3082) Clean up FSDatasetInterface
Date Tue, 13 Mar 2012 18:08:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228550#comment-13228550
] 

Uma Maheswara Rao G commented on HDFS-3082:
-------------------------------------------

Hi Nicholas,
 Just reviewed the patch. 
 Patch looks good to me. Two small nits:

1) FSDataset:
 I think we can remove this import now.
 {code}
 import org.apache.hadoop.hdfs.server.datanode.FSDatasetInterface.FSVolumeInterface;
 {code}

2) SimulatedFSDataSet:

{code}
-  @Override // FSDatasetInterface
-  public synchronized InputStream getBlockInputStream(ExtendedBlock b)
-      throws IOException {
+  synchronized InputStream getBlockInputStream(ExtendedBlock b
+      ) throws IOException {
{code}

We can keep @Override back right?
And 2 tests skipped are seems to be unrelated. and you also please comment on test results.


Thanks
Uma
                
> Clean up FSDatasetInterface
> ---------------------------
>
>                 Key: HDFS-3082
>                 URL: https://issues.apache.org/jira/browse/HDFS-3082
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h3082_20120312.patch
>
>
> Some methods defined in FSDatasetInterface are actually not needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message