hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3167) CLI-based driver for MiniDFSCluster
Date Sat, 31 Mar 2012 00:51:26 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242898#comment-13242898
] 

Aaron T. Myers commented on HDFS-3167:
--------------------------------------

Hey Henry, patch looks pretty good after a quick look. I haven't actually run it, though.
Can you comment on what testing you've done?

A few little things I noticed:

# Why do you initialize nameNodePort to 20500? I don't think it will actually get used, since
you later specify "0" as the default.
# It's not obvious to me why you output some error messages using LOG.info(...), and others
using System.err.println(...). Unless there's some good reason, I'd suggest you either be
consistent or add a comment explaining what the distinction for using one vs. the other is.
# I don't see how stop(...) will ever be called.
                
> CLI-based driver for MiniDFSCluster
> -----------------------------------
>
>                 Key: HDFS-3167
>                 URL: https://issues.apache.org/jira/browse/HDFS-3167
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: HDFS-3167.patch
>
>
> Picking up a thread again from MAPREDUCE-987, I've found it very useful to have a CLI
driver for running a single-process DFS cluster, particularly when developing features in
HDFS clients. For example, being able to spin up a local cluster easily was tremendously useful
for correctness testing of HDFS-2834. 
> I'd like to contribute a class based on the patch for MAPREDUCE-987 we've been using
fairly extensively. Only for DFS, not MR since much has changed MR-side since the original
patch. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message