Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 15 Feb 2012 19:45:00 +0000 (UTC)
From: "Todd Lipcon (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <931324257.42203.1329335100044.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1204176314.3366.1321986040071.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2586) Add protobuf service and
 implementation for HAServiceProtocol
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208723#comment-13208723 ] 

Todd Lipcon commented on HDFS-2586:
-----------------------------------

The bug is here -- missing "break"s:
{code}
+    HAServiceStateProto ret;
+    switch (s) {
+    case ACTIVE:
+      ret = HAServiceStateProto.ACTIVE;
+    case STANDBY:
+      ret = HAServiceStateProto.STANDBY;
+    default:
+    case INITIALIZING:
+      ret = HAServiceStateProto.INITIALIZING;
+    }
{code}
                
> Add protobuf service and implementation for HAServiceProtocol
> -------------------------------------------------------------
>
>                 Key: HDFS-2586
>                 URL: https://issues.apache.org/jira/browse/HDFS-2586
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: HA branch (HDFS-1623)
>
>         Attachments: HDFS-2586.txt, HDFS-2586.txt
>
>
> When the trunk moves to protobuf based RPC, HAServiceProtocol should have equivalent protobuf implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira