Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 16 Feb 2012 18:11:04 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <765520102.47055.1329415864983.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1405318268.43317.1329346919799.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2955) HA: IllegalStateException during
 standby startup in getCurSegmentTxId
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209559#comment-13209559 ] 

Aaron T. Myers commented on HDFS-2955:
--------------------------------------

bq. @aaron - can you please add the test - which should have been part of HDFS-2943.

HDFS-2943 was done on trunk/0.23, where there is no Standby NN.

bq. I believe this patch is good to go without tests, because it is a simple change.

The patch outputs the wrong value for the metric in the case of the standby NN. Since there are no tests, I only discovered this upon manual inspection.
                
> HA: IllegalStateException during standby startup in getCurSegmentTxId
> ---------------------------------------------------------------------
>
>                 Key: HDFS-2955
>                 URL: https://issues.apache.org/jira/browse/HDFS-2955
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>         Attachments: HDFS-2955-HDFS-1623.patch, HDFS-2955-HDFS-1623.patch
>
>
> During standby restarts, a new routine getTransactionsSinceLastLogRoll() has been introduced for metrics which is calling getCurSegmentTxId(). checkstate() in getCurSegmentTxId() assumes that log is opened for writing and this is not the case in standby.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira