Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 610109E5A for ; Tue, 28 Feb 2012 17:34:31 +0000 (UTC) Received: (qmail 16929 invoked by uid 500); 28 Feb 2012 17:34:31 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 16902 invoked by uid 500); 28 Feb 2012 17:34:31 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 16893 invoked by uid 99); 28 Feb 2012 17:34:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 17:34:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 17:34:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5EDE733E798 for ; Tue, 28 Feb 2012 17:33:48 +0000 (UTC) Date: Tue, 28 Feb 2012 17:33:48 +0000 (UTC) From: "Todd Lipcon (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <623738657.28866.1330450428401.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1261620736.26610.1330405128957.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-3023) Optimize entries in edits log for persistBlocks calls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218384#comment-13218384 ] Todd Lipcon commented on HDFS-3023: ----------------------------------- bq. though why does updating block info also now update mod time and access time I just moved the following code: {code} - // Update the salient file attributes. - file.setAccessTime(addCloseOp.atime); - file.setModificationTimeForce(addCloseOp.mtime); {code} since OP_ADD contains those pieces of info, but OP_UPDATE_BLOCKS doesn't. > Optimize entries in edits log for persistBlocks calls > ----------------------------------------------------- > > Key: HDFS-3023 > URL: https://issues.apache.org/jira/browse/HDFS-3023 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node, performance > Affects Versions: HA branch (HDFS-1623), 0.23.2 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-3023-HDFS-1623.txt > > > One of the performance issues noticed in the HA branch is due to the much larger edit logs, now that we are writing OP_ADD transactions to the edit log on every block allocation. We can condense these calls down in two ways: > 1) use variable-length integers for the block list length, size, and genstamp (most of these end up fitting in far less than 8 bytes) > 2) use delta-coding for the genstamp and block size for any blocks after the first block (most blocks will be the same size and only slightly higher genstamps) > 3) introduce a new OP_UPDATE_BLOCKS transaction that doesn't re-serialize metadata information like lease owner, permissions, etc > 4) allow OP_UPDATE_BLOCKS to only re-serialize the blocks that have changed for a given transaction -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira