Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 23 Feb 2012 18:28:49 +0000 (UTC)
From: "Colin Patrick McCabe (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <221908193.10779.1330021729019.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1265970225.7692.1329962748798.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2990) Move OfflineImageViewer,
 OfflineEditsViewer into the same package as the NameNode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214913#comment-13214913 ] 

Colin Patrick McCabe commented on HDFS-2990:
--------------------------------------------

To be honest, I don't see the value add in having the tools in a separate package.  These tools are tied in pretty deeply to the NameNode format.  It's silly to pretend like they're a separate, completely independent module.

As Aaron pointed out, the alternative for us would be making a lot of things public and using @Interface unstable, or similar.  That seems messy to me, which is why I proposed this.  What do you think?
                
> Move OfflineImageViewer, OfflineEditsViewer into the same package as the NameNode
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-2990
>                 URL: https://issues.apache.org/jira/browse/HDFS-2990
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-2990.patch
>
>
> Since OfflineImageviewer and OfflineEditsVeiwer are in different namespaces than the NameNode, we can't ruuse a lot of the code from the NameNode without making things public that we probably don't want to make public.  Let's move them into the NameNode namespace to avoid this problem.  These tools will always be tightly tied to the NameNode anyway (they are parsing the same on-disk structures, after all), so that is where they belong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira