Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 23 Feb 2012 19:12:54 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <2040502077.10971.1330024374044.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1651846471.10655.1330019689024.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-3002) TestNameNodeMetrics need not wait
 for metrics update with new metrics framework
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214947#comment-13214947 ] 

Aaron T. Myers commented on HDFS-3002:
--------------------------------------

bq. After looking at the patch on HDFS-2966, these are unrelated issues. I am removing updateMetrics() method calls.

Not entirely unrelated. The patch for HDFS-2966 is also removing a few calls to updateMetrics(...), but only those which pertain to DN metrics, which still do take a little time to update. In your patch, you replaced those particular calls to direct calls to Thread.sleep(...).

Regardless, the patch here looks good to me. +1. Once this is committed, we'll just have to rev the patch for HDFS-2966 a little bit, since I'm pretty sure they'll conflict slightly.
                
> TestNameNodeMetrics need not wait for metrics update with new metrics framework
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-3002
>                 URL: https://issues.apache.org/jira/browse/HDFS-3002
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Trivial
>         Attachments: HDFS-3002.patch
>
>
> With older metrics framework, the namenode metrics was updated by replication thread. This required test having to wait for replication interval. This is no longer necessary with metrics2 framework. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira