Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 23 Feb 2012 16:28:49 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1893452766.10404.1330014529563.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1158488248.10355.1330013568877.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2998) OfflineImageViewer and ImageVisitor
 should be annotated public
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214837#comment-13214837 ] 

Aaron T. Myers commented on HDFS-2998:
--------------------------------------

bq. Why are they public API? When we added these classes the intent was to use it with in HDFS and not make is available publicly.

Ah, sorry. I'm not familiar with the development history of it.

Regardless, even if it's not its originally-intended purpose, I do think it's a useful interface for users outside of the project to be able to extend. Would you object to marking it InterfaceAudience.Public, InterfaceStability.Evolving?
                
> OfflineImageViewer and ImageVisitor should be annotated public
> --------------------------------------------------------------
>
>                 Key: HDFS-2998
>                 URL: https://issues.apache.org/jira/browse/HDFS-2998
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.1
>            Reporter: Aaron T. Myers
>
> The OfflineImageViewer is currently annotated as InterfaceAudience.Private. It's intended for subclassing, so it should be annotated as the public API that it is.
> The ImageVisitor class should similarly be annotated public (evolving is fine). Note that it should also be changed to be public; it's currently package-private, which means that users have to cheat with their subclass package name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira