Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 486AA9FE0 for ; Tue, 14 Feb 2012 01:07:25 +0000 (UTC) Received: (qmail 52132 invoked by uid 500); 14 Feb 2012 01:07:25 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 52052 invoked by uid 500); 14 Feb 2012 01:07:24 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 52044 invoked by uid 99); 14 Feb 2012 01:07:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 01:07:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2012 01:07:22 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2CBF01B5517 for ; Tue, 14 Feb 2012 01:07:01 +0000 (UTC) Date: Tue, 14 Feb 2012 01:07:01 +0000 (UTC) From: "Aaron T. Myers (Updated) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1492441187.34717.1329181621184.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1527716965.34629.1329180899445.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-2947) HA: On startup NN throws an NPE in the metrics system MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron T. Myers updated HDFS-2947: --------------------------------- Attachment: HDFS-2947-HDFS-1623.patch Here's a patch which addresses the issue. I manually verified that the NN no longer prints this NPE during startup. I also ran TestHAStateTransitions to make sure everything still works fine. > HA: On startup NN throws an NPE in the metrics system > ----------------------------------------------------- > > Key: HDFS-2947 > URL: https://issues.apache.org/jira/browse/HDFS-2947 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node > Affects Versions: HA branch (HDFS-1623) > Reporter: Aaron T. Myers > Assignee: Aaron T. Myers > Priority: Minor > Attachments: HDFS-2947-HDFS-1623.patch > > > HDFS-2510 added some HA-specific metrics which check the NN's HAState. The NN initializes its HAState *after* the metrics are initialized, and thus we might hit an NPE during NN startup. This seems to be innocuous in that the NN's metrics still function, but it's poor form to log an unnecessary NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira