Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 4 Feb 2012 01:51:53 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1032508090.10487.1328320313600.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <480730237.34815.1326384459900.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2786) Fix host-based token
 incompatibilities in DFSUtil
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200263#comment-13200263 ] 

Hadoop QA commented on HDFS-2786:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12513216/hdfs-2786.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1840//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1840//console

This message is automatically generated.
                
> Fix host-based token incompatibilities in DFSUtil
> -------------------------------------------------
>
>                 Key: HDFS-2786
>                 URL: https://issues.apache.org/jira/browse/HDFS-2786
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node, security
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Daryn Sharp
>            Assignee: Kihwal Lee
>         Attachments: hdfs-2786.patch, hdfs-2786.patch
>
>
> DFSUtil introduces new static methods that duplicate functionality in NetUtils.  These new methods lack the logic necessary for host-based tokens to work.  After speaking with Suresh, the approach being taken is:
> * DFSUtil.getSocketAddress will be removed.  Callers will be reverted to using the NetUtils version.
> * DFSUtil.getDFSClient will changed to take accept a uri/host:port string instead of an InetSocketAddress.  The method will internal call NetUtils.createSocketAddr. This alleviates the callers from being required to call NetUtils.createSocketAddr and reduce the opportunity for error that will break host-based tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira