hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3014) FSEditLogOp and its subclasses should have toString() method
Date Sun, 26 Feb 2012 05:40:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216637#comment-13216637
] 

Aaron T. Myers commented on HDFS-3014:
--------------------------------------

OK then, fine by me.

One other comment then: I think we should refactor the toString methods of AddOp and CloseOp,
since they're almost identical and those classes have a common superclass. Perhaps AddCloseOp
could have a "stringifyMembers()" method which the subclasses could call?

+1 once this is addressed.
                
> FSEditLogOp and its subclasses should have toString() method
> ------------------------------------------------------------
>
>                 Key: HDFS-3014
>                 URL: https://issues.apache.org/jira/browse/HDFS-3014
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>         Attachments: HDFS-3014.txt
>
>
> FSEditLogOp and its subclasses should have toString() method.
> It's helpful for investigating editlog related issues.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message