hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2907) Make FSDataset in Datanode Pluggable
Date Tue, 21 Feb 2012 22:58:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213082#comment-13213082
] 

Suresh Srinivas commented on HDFS-2907:
---------------------------------------

Comments:
# DFSConfigKeys.java - move the newly added key to the section with "Keys with no defaults"
# Some lines in Datanode.java more than 80 columns
# I would have preferred to have a method initStorage(factory) and move the code from initBlockPool().
# FSDatasetInterface.java - remove unnecesarry cast to Factory
# SimulatedFSDataset.setStimulatedFSDataset - method namenode could be setFactory?
# Since you are changing SimlulatedFSDataset.java - can you please change getBlockReport()
where after using map, we check for map != null.
# Do not throw IOException from TestSimulatedFSDataset#getSimulatedFSDataset()

                
> Make FSDataset in Datanode Pluggable
> ------------------------------------
>
>                 Key: HDFS-2907
>                 URL: https://issues.apache.org/jira/browse/HDFS-2907
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h2907_20120216.patch, h2907_20120217.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message