hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2955) HA: IllegalStateException during standby startup in getCurSegmentTxId
Date Thu, 16 Feb 2012 03:37:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209100#comment-13209100
] 

Aaron T. Myers commented on HDFS-2955:
--------------------------------------

bq. Yes, looks tests started failing due to this. Thanks Hari, for filing the JIRA.

Uma, I'd be pretty surprised if this test failure were due to this change. This change should
only cause an error to be logged to the NN log, and cause the metric not to be output. Also,
TestQuotasWithHA passes for me locally on the HA branch.

Hari, rather than push down the standby state into FSEditLog, why not just make the TransactionsSinceLastLogRoll
metric always output 0 in the case of the standby? This seems correct, since the Standby doesn't
read from in-progress edit logs, and wil fix this bug as well.

Also, it should be pretty easy to write a simple test for this. See TestNameNodeMetrics for
an example.
                
> HA: IllegalStateException during standby startup in getCurSegmentTxId
> ---------------------------------------------------------------------
>
>                 Key: HDFS-2955
>                 URL: https://issues.apache.org/jira/browse/HDFS-2955
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>         Attachments: HDFS-2955-HDFS-1623.patch
>
>
> During standby restarts, a new routine getTransactionsSinceLastLogRoll() has been introduced
for metrics which is calling getCurSegmentTxId(). checkstate() in getCurSegmentTxId() assumes
that log is opened for writing and this is not the case in standby.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message