hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2990) Move OfflineImageViewer, OfflineEditsViewer into the same package as the NameNode
Date Thu, 23 Feb 2012 14:58:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214787#comment-13214787
] 

Aaron T. Myers commented on HDFS-2990:
--------------------------------------

bq. This does not sound a good reason to move the tools to the namenode package. Otherwise,
we will end up with everything in the same package.

Hey Nicholas, do you have an alternative suggestion? Would you be OK with changing a few things
in o.a.h.hdfs.server.namenode public that otherwise wouldn't need to be? Certainly having
to copy/paste the code would be a real shame.
                
> Move OfflineImageViewer, OfflineEditsViewer into the same package as the NameNode
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-2990
>                 URL: https://issues.apache.org/jira/browse/HDFS-2990
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-2990.patch
>
>
> Since OfflineImageviewer and OfflineEditsVeiwer are in different namespaces than the
NameNode, we can't ruuse a lot of the code from the NameNode without making things public
that we probably don't want to make public.  Let's move them into the NameNode namespace to
avoid this problem.  These tools will always be tightly tied to the NameNode anyway (they
are parsing the same on-disk structures, after all), so that is where they belong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message