hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2863) Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
Date Thu, 02 Feb 2012 23:54:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199380#comment-13199380

Aaron T. Myers commented on HDFS-2863:

bq. I added the TestFSNamesystem to be a class for adding future unit tests for the same source
class. The test is not really HA specific since the dups can occur in the edits.dirs config
itself right?

The test is HA-specific in that it's meant to test configuration of the shared edits dir,
which itself is HA-specific. The fact that it also happens to test for overlaps within the
edits dir configuration seems incidental to me. In fact, I would prefer if the test were more
isolated so that it *doesn't* test for overlaps within the edits dir configuration. We should
add a separate test for that behavior.

bq. The unit test tests what the function does. So IMO it makes sense the way its written
currently. The fact that we currently support a single shared edits dir is not related to
the test and should be ideally covered in a functional sanity test for the HA config feature

Sure, but the test is strictly _less realistic_ than it could be because of this. Better to
verify the behavior under the conditions we expect users to use, rather than some theoretical
case which isn't currently supported.

Also, if the test is left as-is, whenever HDFS-2752 gets implemented, this test will need
to be amended because it will no longer be valid.
> Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
> ------------------------------------------------------------------------------
>                 Key: HDFS-2863
>                 URL: https://issues.apache.org/jira/browse/HDFS-2863
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Jitendra Nath Pandey
>            Assignee: Bikas Saha
>         Attachments: HDFS-2863.HDFS-1623.patch, HDFS-2863.HDFS-1623.patch, HDFS-2863.HDFS-1623.patch
> If same edits directory is configured in twice, both are treated independently. Edit
log roll is called on the same directory twice causing exceptions.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message