hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2718) Optimize OP_ADD in edits loading
Date Fri, 03 Feb 2012 05:45:56 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199535#comment-13199535
] 

Konstantin Shvachko commented on HDFS-2718:
-------------------------------------------

Intended to fix CreateEditLogs in a subsequent jira. Got the patch ready.
Will cleanup the parameters in there as well.
As for "(startIndex + i)", my patch does exactly the same as HDFS-2602, except the latter
adds "-" between the stringified numbers. If you insist I'll reuse the code from your patch
for TestEditLog. But I don't see a bug here as long as the file names generated by different
threads are disjoint, which was a bug in the original code.
Thanks for the feedback.
                
> Optimize OP_ADD in edits loading
> --------------------------------
>
>                 Key: HDFS-2718
>                 URL: https://issues.apache.org/jira/browse/HDFS-2718
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0, 0.24.0, 1.0.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.24.0, 0.23.1, 0.22.1
>
>         Attachments: editsLoader-0.22.patch, editsLoader-0.22.patch, editsLoader-0.22.patch,
editsLoader-trunk.patch, editsLoader-trunk.patch, editsLoader-trunk.patch, editsLoader-trunk.patch
>
>
> During loading the edits journal FSEditLog.loadEditRecords() processes OP_ADD inefficiently.
It first removes the existing INodeFile from the directory tree, then adds it back as a regular
INodeFile, and then replaces it with INodeFileUnderConstruction if files is not closed. This
slows down edits loading. OP_ADD should be done in one shot and retain previously existing
data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message