Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40AF39709 for ; Sat, 28 Jan 2012 20:38:32 +0000 (UTC) Received: (qmail 86793 invoked by uid 500); 28 Jan 2012 20:38:32 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 86766 invoked by uid 500); 28 Jan 2012 20:38:31 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86758 invoked by uid 99); 28 Jan 2012 20:38:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jan 2012 20:38:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jan 2012 20:38:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1D3301697A6 for ; Sat, 28 Jan 2012 20:38:10 +0000 (UTC) Date: Sat, 28 Jan 2012 20:38:10 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <597778910.4784.1327783090121.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <709322931.12914.1325814339308.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2759) Pre-allocate HDFS edit log files after writing version number MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195620#comment-13195620 ] Hudson commented on HDFS-2759: ------------------------------ Integrated in Hadoop-Common-trunk-Commit #1613 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1613/]) HDFS-2759. Pre-allocate HDFS edit log files after writing version number. Contributed by Aaron T. Myers. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237153 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogFileOutputStream.java > Pre-allocate HDFS edit log files after writing version number > ------------------------------------------------------------- > > Key: HDFS-2759 > URL: https://issues.apache.org/jira/browse/HDFS-2759 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha, name-node > Affects Versions: 0.24.0 > Reporter: Aaron T. Myers > Assignee: Aaron T. Myers > Fix For: 0.24.0 > > Attachments: HDFS-2759.patch, HDFS-2759.patch, HDFS-2759.patch > > > In HDFS-2709 it was discovered that there's a potential race wherein edits log files are pre-allocated before the version number is written into the header of the file. This can cause the NameNode to read an invalid HDFS layout version, and hence fail to read the edit log file. We should write the header, then pre-allocate the rest of the file after this point. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira