Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 6 Jan 2012 01:45:39 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1174533145.12918.1325814339512.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <638674419.3794.1325666380365.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2749) Wrong fsimage format while entering
 recovery mode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181035#comment-13181035 ] 

Hadoop QA commented on HDFS-2749:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12509642/patch+for+hdfs2749.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1761//console

This message is automatically generated.
                
> Wrong fsimage format while entering recovery mode
> -------------------------------------------------
>
>                 Key: HDFS-2749
>                 URL: https://issues.apache.org/jira/browse/HDFS-2749
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Denny Ye
>            Priority: Critical
>              Labels: hdfs
>         Attachments: patch for hdfs2749.txt
>
>
> hadoop is into a recovery mode and save namespace to disk before the system starting service. however, there are many situation will cause hadoop enter recovery mode like missing VERSION file and ckpt file exists due to last failure of checkpoint.
> in recovery mode, namespace is loaded from previous fsimage, and the default numFiles of namespace.rootDir is 1. the numFiles number is read from fsimage (readInt as version, readInt as namespaceId, readLong as numFiles).
> the numFiles number is not updated in namespace when saving namespace.
> save namespace just after load fsimage which actually write numFiles which is default value 1 to disk.
> the next time to load the saved fsimage from disk when rebooting or secondarynamenode doing checkpoint, the system will crash (OOM) because this fsimage is incorrect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira