From hdfs-issues-return-32807-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org Wed Jan 25 03:07:19 2012 Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26D8B9E82 for ; Wed, 25 Jan 2012 03:07:19 +0000 (UTC) Received: (qmail 86797 invoked by uid 500); 25 Jan 2012 03:07:17 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 86581 invoked by uid 500); 25 Jan 2012 03:07:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86570 invoked by uid 99); 25 Jan 2012 03:07:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2012 03:07:04 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=5.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2012 03:07:03 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0EBE016127C for ; Wed, 25 Jan 2012 03:06:43 +0000 (UTC) Date: Wed, 25 Jan 2012 03:06:43 +0000 (UTC) From: "Sanjay Radia (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <234313737.75470.1327460803099.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1985997259.41976.1326603039586.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2791) If block report races with closing of file, replica is incorrectly marked corrupt MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192831#comment-13192831 ] Sanjay Radia commented on HDFS-2791: ------------------------------------ >Case 2 .... I agree that it it is safer to ignore it if the gen-stamp AND length match rather than mark the replica as corrupt. >HA case .. block will be marked as corrupt till next full block report. Isn't this addressed by one of 2 events: * the AddBlock from the DN arrive at the NNB shortly after the Block report containing RBW. (but it may get lost) * The Op_Add contains the block location ( I don't think it contains the block location). > If block report races with closing of file, replica is incorrectly marked corrupt > --------------------------------------------------------------------------------- > > Key: HDFS-2791 > URL: https://issues.apache.org/jira/browse/HDFS-2791 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, name-node > Affects Versions: 0.22.0, 0.23.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-2791-test.txt, hdfs-2791.txt, hdfs-2791.txt, hdfs-2791.txt > > > The following sequence of events results in a replica mistakenly marked corrupt: > 1. Pipeline is open with 2 replicas > 2. DN1 generates a block report but is slow in sending to the NN (eg some flaky network). It gets "stuck" right before the block report RPC. > 3. Client closes the file. > 4. DN2 is fast and sends blockReceived to the NN. NN marks the block as COMPLETE > 5. DN1's block report proceeds, and includes the block in an RBW state. > 6. (x) NN incorrectly marks the replica as corrupt, since it is an RBW replica on a COMPLETE block. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira