hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1910) when dfs.name.dir and dfs.name.edits.dir are same fsimage will be saved twice every time
Date Fri, 06 Jan 2012 00:59:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181008#comment-13181008
] 

Aaron T. Myers commented on HDFS-1910:
--------------------------------------

bq. It's up to Konstantin to commit to 1.1 if he wants; he has a committer's +1 to do so.

I know that. Like I said - I'm not going to block it.

bq. This will be a serious pain to test in a true unit test, 

We do these sorts of tests all the time with Mockito.spy, Mockito.verify, and Mockito.times.

bq. so rather than wait for someone to write that code, I'd rather get the signficant startup
time improvement in. Yeah, it'd be great to have a test - and if it were at all possible this
could cause a data loss, I'd insist on it - but people's time is limited.

Sure, no objection. I just asked for a test as I do for all code I review which doesn't have
test coverage. It's your prerogative if you want to ignore that request, or punt it to another
JIRA.
                
> when dfs.name.dir and dfs.name.edits.dir are same fsimage will be saved twice every time
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1910
>                 URL: https://issues.apache.org/jira/browse/HDFS-1910
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Gokul
>            Priority: Minor
>              Labels: critical-0.22.0
>             Fix For: 0.22.1
>
>         Attachments: saveImageOnce-v0.22.patch
>
>
> when image and edits dir are configured same, the fsimage flushing from memory to disk
will be done twice whenever saveNamespace is done. this may impact the performance of backupnode/snn
where it does a saveNamespace during every checkpointing time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message