hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2592) HA: Balancer support for HA namenodes
Date Wed, 11 Jan 2012 05:34:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183876#comment-13183876
] 

Todd Lipcon commented on HDFS-2592:
-----------------------------------

This looks fairly reasonable. A few items:
- Is it possible to move that new code out of the NameNodeConnector constructor into a static
method in DFSUtil or even DFSClient?
- Rather than duplicating the code to parse the maxFailoverAttempts, failoverBaseSleepMillis,
etc, can we reuse some of the code that's in DFSClient? If we move the connection code into
a static method in DFSClient, then we can instantiate a DFSClient.Conf and pull out the variables
from there, for example.
- Some too-long lines in the new test code
- The new test is mostly dup code from TestBalancer. Is it possible to reuse more of the code
by refactoring into static methods, etc?
- Similarly much of the setup code is duplicated from HAUtil.configureFailoverFs. Can you
just call that function, then grab the conf from the resulting filesystem, or refactor that
method so you can reuse the configuration generating code?
                
> HA: Balancer support for HA namenodes
> -------------------------------------
>
>                 Key: HDFS-2592
>                 URL: https://issues.apache.org/jira/browse/HDFS-2592
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer, ha
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2592.patch, HDFS-2592.patch
>
>
> The balancer currently interacts directly with namenode InetSocketAddresses and makes
its own IPC proxies. We need to integrate it with HA so that it uses the same client failover
infrastructure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message