hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1841) Enforce read-only permissions in FUSE open()
Date Tue, 03 Jan 2012 22:46:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179096#comment-13179096
] 

Hadoop QA commented on HDFS-1841:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12509341/patch.fuse-dfs.kernel
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 20 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings (more than the
trunk's current 0 warnings).

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1752//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1752//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1752//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1752//console

This message is automatically generated.
                
> Enforce read-only permissions in FUSE open()
> --------------------------------------------
>
>                 Key: HDFS-1841
>                 URL: https://issues.apache.org/jira/browse/HDFS-1841
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: contrib/fuse-dfs
>    Affects Versions: 0.20.2
>         Environment: Linux 2.6.35
>            Reporter: Brian Bloniarz
>            Priority: Minor
>         Attachments: patch.fuse-dfs, patch.fuse-dfs.kernel
>
>
> fuse-dfs currently allows files to be created on a read-only filesystem:
> $ fuse_dfs_wrapper.sh dfs://example.com:8020 ro ~/hdfs
> $ touch ~/hdfs/foobar
> Attached is a simple patch, which does two things:
> 1) Checks the read_only flag inside dfs_open().
> 2) Passes the read-only mount option to FUSE when ro is specified on the commandline.
This is probably a better long-term solution; the kernel will enforce the read-only operations
without it being necessary inside the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message