hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2805) HA: Add a test for a federated cluster with HA NNs
Date Thu, 26 Jan 2012 07:54:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193640#comment-13193640
] 

Aaron T. Myers commented on HDFS-2805:
--------------------------------------

Thanks a lot for addressing most of my concerns, Brandon. A few more comments:

bq. 3. the problem was only in first patch

Not true. It was a problem in the third patch, and it's still a problem in the fourth patch.
The two definitions of HATestUtil#configureFailoverFs are identical, except for the nsIndex.
Please fix this.

bq. 4. fixed using 2nd approach you recommended

Close, but not quite what I intended. There's no need to include "DefaultNs" in the method
name. Just use the same name as the other method, but with a different signature. This way
you won't have to update TestBalancerWithHANameNodes at all.

A few more comments, mostly nits:

# The new log messages in TestHAStateTransitions#testManualFailoverFailback should have a
space between "namespace" and the nsIndex.
# setFailoverConfigurationsDefaultNs - looks like you introduced a tab, in addition to some
spaces, at the beginning of this line. Please use only spaces.
# testManualFOFBFederationHA - please don't abbreviate "FOFB"
                
> HA: Add a test for a federated cluster with HA NNs
> --------------------------------------------------
>
>                 Key: HDFS-2805
>                 URL: https://issues.apache.org/jira/browse/HDFS-2805
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Brandon Li
>         Attachments: HDFS-2805.3.txt, HDFS-2805.4.txt, HDFS-2805.second.txt, HDFS-2805.txt
>
>
> Add a test for configuring/interacting with a federated cluster wherein each name service
is itself HA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message