hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2767) HA: ConfiguredFailoverProxyProvider should support NameNodeProtocol
Date Tue, 17 Jan 2012 01:29:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187364#comment-13187364
] 

Uma Maheswara Rao G commented on HDFS-2767:
-------------------------------------------

Thanks Todd, for the clarification.

{quote}
+    } catch (RuntimeException rte) {
+      throw rte;

doesn't serve any purpose
{quote}
Oops..did not realize while merging from the patch. 

{quote}
    *  The functions createFailoverProxyWithNamenodeProtocol and createFailoverProxyWithClientProtocol
are identical except for the class they take, right? Why not just make it take the interface
class as a third parameter?
{quote}
Done.

{quote}
Can you update NameNodeConnector.createNamenode to call createNNProxyWithNamenodeProtocol
in this patch, just so we don't introduce new dup code here?
{quote}
Done.

Thanks
Uma
                
> HA: ConfiguredFailoverProxyProvider should support NameNodeProtocol
> -------------------------------------------------------------------
>
>                 Key: HDFS-2767
>                 URL: https://issues.apache.org/jira/browse/HDFS-2767
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, hdfs client
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Blocker
>         Attachments: HDFS-2767.patch, HDFS-2767.patch, HDFS-2767.patch, hdfs-2767-what-todd-had.txt
>
>
> Presentely ConfiguredFailoverProxyProvider supports ClinetProtocol.
> It should support NameNodeProtocol also, because Balancer uses NameNodeProtocol for getting
blocks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message