hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2747) HA: entering safe mode after starting SBN can NPE
Date Mon, 16 Jan 2012 14:52:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186950#comment-13186950
] 

Uma Maheswara Rao G commented on HDFS-2747:
-------------------------------------------

Todd, Thanks a lot for the review!

{quote}
# add braces around the body of the new if statement
# typo in test name: "ShoulNot"
{quote}
Done. & thanks for noticing typo.

{quote}
parameter should capitalize "namesystem" not "nameSystem" since it is FSNamesystem, not FSNameSystem

    * I also think NameNodeAdapter is probably a better spot for this than FSImageTestUtil
{quote}
I did not fix this comment, because now i used other api which is already exist in NameNodeAdapter.
Thanks for pointing NameNodeAdapter to use. 

{quote}
# In the javadoc for the new tests, can you mention that it is a regression test for HDFS-2747?
I think it's useful for future maintenance of the tests to be able to refer back to the discussion
on this bug.
{quote}
Added in comment.

Thanks
Uma
                
> HA: entering safe mode after starting SBN can NPE
> -------------------------------------------------
>
>                 Key: HDFS-2747
>                 URL: https://issues.apache.org/jira/browse/HDFS-2747
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Eli Collins
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2747.patch, HDFS-2747.patch
>
>
> Entering Safemode on the primary after while it's already in safemode after the SBN is
started results in an NPE: 
> {noformat}
> hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs dfsadmin -safemode get
> Safe mode is ON
> hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs dfsadmin -safemode enter
> safemode: java.lang.NullPointerException
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message