hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-554) BlockInfo.ensureCapacity may get a speedup from System.arraycopy()
Date Sun, 01 Jan 2012 12:01:30 GMT

    [ https://issues.apache.org/jira/browse/HDFS-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178147#comment-13178147

Harsh J commented on HDFS-554:

Findbugs result is not related to this. Committing. Thanks for the review guys!
> BlockInfo.ensureCapacity may get a speedup from System.arraycopy()
> ------------------------------------------------------------------
>                 Key: HDFS-554
>                 URL: https://issues.apache.org/jira/browse/HDFS-554
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.24.0
>         Attachments: HDFS-554.patch, HDFS-554.txt, HDFS-554.txt
> BlockInfo.ensureCapacity() uses a for() loop to copy the old array data into the expanded
array.  {{System.arraycopy()}} is generally much faster for this, as it can do a bulk memory
copy. There is also the typesafe Java6 {{Arrays.copyOf()}} to consider, though here it offers
no tangible benefit.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message