Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 9 Dec 2011 18:42:43 +0000 (UTC)
From: "Todd Lipcon (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <435101608.59406.1323456163698.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <571102347.28753.1321312432688.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2553) BlockPoolSliceScanner spinning in
 loop
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166423#comment-13166423 ] 

Todd Lipcon commented on HDFS-2553:
-----------------------------------

Hey Uma, sorry I missed the patch upload before. One nit:
{code}
-            || (!(this.isFirstBlockProcessed()))) {
+            || (blockInfoSet.size() > 0 && !(this.isFirstBlockProcessed()))) {
{code}
can you use {{!blockInfoSet.isEmpty()}} instead of checking {{size()}}? Should be faster for many collection types.
                
> BlockPoolSliceScanner spinning in loop
> --------------------------------------
>
>                 Key: HDFS-2553
>                 URL: https://issues.apache.org/jira/browse/HDFS-2553
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Todd Lipcon
>            Priority: Critical
>         Attachments: CPUUsage.jpg, HDFS-2553.patch
>
>
> Playing with trunk, I managed to get a DataNode in a situation where the BlockPoolSliceScanner is spinning in the following loop, using 100% CPU:
>         at org.apache.hadoop.hdfs.server.datanode.DataNode$BPOfferService.isAlive(DataNode.java:820)
>         at org.apache.hadoop.hdfs.server.datanode.DataNode.isBPServiceAlive(DataNode.java:2962)
>         at org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceScanner.scan(BlockPoolSliceScanner.java:625)
>         at org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceScanner.scanBlockPoolSlice(BlockPoolSliceScanner.java:614)
>         at org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.run(DataBlockScanner.java:95)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira