Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 488199708 for ; Sat, 10 Dec 2011 02:33:03 +0000 (UTC) Received: (qmail 87716 invoked by uid 500); 10 Dec 2011 02:33:03 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 87682 invoked by uid 500); 10 Dec 2011 02:33:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 87674 invoked by uid 99); 10 Dec 2011 02:33:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 02:33:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 02:33:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 005BF10AABB for ; Sat, 10 Dec 2011 02:32:40 +0000 (UTC) Date: Sat, 10 Dec 2011 02:32:39 +0000 (UTC) From: "Uma Maheswara Rao G (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1542113986.61164.1323484360002.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <571102347.28753.1321312432688.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2553) BlockPoolSliceScanner spinning in loop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166752#comment-13166752 ] Uma Maheswara Rao G commented on HDFS-2553: ------------------------------------------- Hi Todd, Thanks for the review! Updated the patch! changed to (!blockInfoSet.isEmpty() && !(this.isFirstBlockProcessed()))) { Also retained the isEmpty condition in isFirstBlockProcessed because previous(above) check was not there in synchronization. So, there is a chance that block can be removed when just entering into isFirstBlockProcessed. Thanks Uma > BlockPoolSliceScanner spinning in loop > -------------------------------------- > > Key: HDFS-2553 > URL: https://issues.apache.org/jira/browse/HDFS-2553 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 0.23.0, 0.24.0 > Reporter: Todd Lipcon > Assignee: Uma Maheswara Rao G > Priority: Critical > Attachments: CPUUsage.jpg, HDFS-2553.patch, HDFS-2553.patch > > > Playing with trunk, I managed to get a DataNode in a situation where the BlockPoolSliceScanner is spinning in the following loop, using 100% CPU: > at org.apache.hadoop.hdfs.server.datanode.DataNode$BPOfferService.isAlive(DataNode.java:820) > at org.apache.hadoop.hdfs.server.datanode.DataNode.isBPServiceAlive(DataNode.java:2962) > at org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceScanner.scan(BlockPoolSliceScanner.java:625) > at org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceScanner.scanBlockPoolSlice(BlockPoolSliceScanner.java:614) > at org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.run(DataBlockScanner.java:95) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira