hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2653) DFSClient should cache whether addrs are non-local when short-circuiting is enabled
Date Sun, 11 Dec 2011 00:28:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167017#comment-13167017
] 

Hadoop QA commented on HDFS-2653:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506873/hdfs-2653-2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 90 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1683//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1683//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs-httpfs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1683//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1683//console

This message is automatically generated.
                
> DFSClient should cache whether addrs are non-local when short-circuiting is enabled
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-2653
>                 URL: https://issues.apache.org/jira/browse/HDFS-2653
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1, 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2653-1.patch, hdfs-2653-2.patch, hdfs-2653-2.patch, hdfs-2653-b1-1.patch,
hdfs-2653-b1-2.patch
>
>
> Something Todd mentioned to me off-line.. currently DFSClient doesn't cache the fact
that non-local reads are non-local, so if short-circuiting is enabled every time we create
a block reader we'll go through the isLocalAddress code path. We should cache the fact that
an addr is non-local as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message