hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2679) Add interface to query current state to HAServiceProtocol
Date Wed, 14 Dec 2011 10:02:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169243#comment-13169243
] 

Uma Maheswara Rao G commented on HDFS-2679:
-------------------------------------------

Hi Eli,

 1) can't we name HANameNodeState to some generic way. Because this presents in common and
current name represents more specific to DFS.

2) It will be good if we can use the same enum (HANameNodeState ) to pass to the HAState instaed
of string values with ctors and provide the getState api. So, corresponding HAState can return
its own state.
Also we can avoid the conditional checks. state.getState() should be sufficient.
 {code}
return state.equals(ACTIVE_STATE)
+      ? HANameNodeState.ACTIVE
+      : HANameNodeState.STANDBY;
{code}
 what do you say?


Thanks
Uma
                
> Add interface to query current state to HAServiceProtocol 
> ----------------------------------------------------------
>
>                 Key: HDFS-2679
>                 URL: https://issues.apache.org/jira/browse/HDFS-2679
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2679.txt, hdfs-2679.txt
>
>
> Let's add an interface to HAServiceProtocol to query the current state of a NameNode
for use by the the CLI (HAAdmin) and Web UI (HDFS-2677). This essentially makes the names
"active" and "standby" from ACTIVE_STATE and STANDBY_STATE public interfaces, which IMO seems
reasonable. Unlike the other APIs we should be able to use the interface even when HA is not
enabled (as by default a non-HA NN is active).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message