hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2701) Cleanup FS* processIOError methods
Date Mon, 19 Dec 2011 04:20:30 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172023#comment-13172023
] 

Todd Lipcon commented on HDFS-2701:
-----------------------------------

in open(), if all of them fail to open, we'll have no edits streams... is that taken care
of by 2702?

----

in removeEditsForStorageDir, I think there might be a bug with the following sequence:
- dir holding both edits and image fails
- restoreFailedStorage is called so it is added back to the list for image operations, but
edit logs haven't rolled yet, so it's not in editStreams
- it fails again, so removeEditsForStorageDir is called with a dir that doesn't have any open
stream.

In that case, exitIfInvalidStreams() would exit even though nothing is getting removed.

I guess this is taken care of by HDFS-2702?

----

If the answer to both of the above is yes, then +1 :)
                
> Cleanup FS* processIOError methods
> ----------------------------------
>
>                 Key: HDFS-2701
>                 URL: https://issues.apache.org/jira/browse/HDFS-2701
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2701.txt, hdfs-2701.txt, hdfs-2701.txt, hdfs-2701.txt
>
>
> Let's rename the various "processIOError" methods to be more descriptive. The current
code makes it difficult to identify and reason about bug fixes. While we're at it let's remove
"Fatal" from the "Unable to sync the edit log" log since it's not actually a fatal error (this
is confusing to users). And 2NN "Checkpoint done" should be info, not a warning (also confusing
to users).
> Thanks to HDFS-1073 these issues don't exist on trunk or 23.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message