hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2684) Fix up some failing unit tests on HA branch
Date Fri, 16 Dec 2011 04:31:30 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HDFS-2684:
------------------------------

    Attachment: hdfs-2684.txt

Here's a patch which fixes up most of the unit tests I saw failing in recent builds.

To summarize the changes:

{code}
+    
+    dn.bpRegistrationSucceeded(bpRegistration, getBlockPoolId());
{code}

Fix upgrade tests -- missed this when we broke out the BPOfferService into multiple "actors".

{code}
       
-      if (!editLog.isSegmentOpen()) {
+      if (!editLog.isOpenForWrite()) {
         // During startup, we're already open for write during initialization.
         // TODO(HA): consider adding a startup state?
{code}
Fixes BackupNode: when the BN enters "active" mode, the log is "open for write" but not in
the middle of a segment. So we don't want to try to init the journals again in that case.

- TestDFSUpgrade, TestCheckpoint: fix the expected txids because we now generate new genstamps
(and thus txns) for each new block
- TestDataTransferProtocol: same -- new block allocation bumps genstamp one more time
- TestHeartbeatHandling, FSNamesystem: when there are no commands, it's now an empty array
instead of a null
- TestBackupNode: can't go through the FS interface to read from BackupNode, since that will
throw StandbyException. So we have to go through a "back door" here going directly through
FSN.
                
> Fix up some failing unit tests on HA branch
> -------------------------------------------
>
>                 Key: HDFS-2684
>                 URL: https://issues.apache.org/jira/browse/HDFS-2684
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, test
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-2684.txt
>
>
> To keep moving quickly on the HA branch, we've committed some stuff even though some
unit tests are failing. This JIRA is to take a pass through the failing unit tests and get
back to green (or close to it). If anything turns out to be a major amount of work I'll file
separate JIRAs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message