hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2654) Make BlockReaderLocal not extend RemoteBlockReader2
Date Sat, 10 Dec 2011 04:14:40 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eli Collins updated HDFS-2654:
------------------------------

    Attachment: hdfs-2654-b1-2.patch

Updated patch for branch-1, right one this time. And the previous comment should have referred
to comment #3, the branch-1 patch just needs the comment. 
                
> Make BlockReaderLocal not extend RemoteBlockReader2
> ---------------------------------------------------
>
>                 Key: HDFS-2654
>                 URL: https://issues.apache.org/jira/browse/HDFS-2654
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1, 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2654-1.patch, hdfs-2654-2.patch, hdfs-2654-2.patch, hdfs-2654-b1-1.patch,
hdfs-2654-b1-2.patch
>
>
> The BlockReaderLocal code paths are easier to understand (especially true on branch-1
where BlockReaderLocal inherits code from BlockerReader and FSInputChecker) if the local and
remote block reader implementations are independent, and they're not really sharing much code
anyway. If for some reason they start to share sifnificant code we can make the BlockReader
interface an abstract class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message