hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2701) Cleanup FS* processIOError methods
Date Sun, 18 Dec 2011 18:08:31 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eli Collins updated HDFS-2701:
------------------------------

    Attachment: hdfs-2701.txt

Thanks for the review Todd. Updated patch attach.

#1 Agree, I've done this in HDFS-2702, I was trying to keep this change to just cleanup/refactoring
(the current crazy behavior is actually what causes HDFS-2702!).
#2 Good catch. Fixed.
#3-5 Done.

Wrt testing see my comment in HDFS-2702. The short answer is that aside from the existing
tests which are clean I've done manual testing (failing storage dirs and checkpointing) for
2701-2703 and am working on a unit test that will cover storage dir failures and removal.
                
> Cleanup FS* processIOError methods
> ----------------------------------
>
>                 Key: HDFS-2701
>                 URL: https://issues.apache.org/jira/browse/HDFS-2701
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2701.txt, hdfs-2701.txt, hdfs-2701.txt, hdfs-2701.txt
>
>
> Let's rename the various "processIOError" methods to be more descriptive. The current
code makes it difficult to identify and reason about bug fixes. While we're at it let's remove
"Fatal" from the "Unable to sync the edit log" log since it's not actually a fatal error (this
is confusing to users). And 2NN "Checkpoint done" should be info, not a warning (also confusing
to users).
> Thanks to HDFS-1073 these issues don't exist on trunk or 23.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message