hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2712) setTimes should support only for files and move the atime field down to iNodeFile.
Date Wed, 21 Dec 2011 19:33:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174340#comment-13174340

Uma Maheswara Rao G commented on HDFS-2712:

setTimes() for directories should throw an exception (FileNotFoundException or UnsupportedActionException?)
I think here two cases, one is for non existent file and other is for directories. Both cases
getINodeFile will return null. SO, to throw the exception, FileNotFoundException should be
correct for non existent files and if src is a dir then UnsupportedActionException will have
more meaning?
or since the passed argument value is not expected one, IllegalArgumentException?
> setTimes should support only for files and move the atime field down to iNodeFile.
> ----------------------------------------------------------------------------------
>                 Key: HDFS-2712
>                 URL: https://issues.apache.org/jira/browse/HDFS-2712
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
> After the dicussion in HDFS-2436, unsupported behaviour for setTimes was intentional
> But current INode structure hierarchy seems, it supports atime for directories also.
But as per HADOOP-1869, we are supporting only for files. To avoid the confusions, we can
move the atime fields to INodeFile as we planned to support setTimes only for files. And also
restrict the support for setTimes on directories ( which is implemented with HDFS-2436 ).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message