hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2693) Synchronization issues around state transition
Date Wed, 21 Dec 2011 01:21:30 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173731#comment-13173731

Eli Collins commented on HDFS-2693:

Can't we nuke the new code in commitBlockSynchronization since we should never execute this,
ie we don't need a TODO here right?

Nit: HAContext needs javadocs for new methods.

Otherwise looks great. Didn't see any synchronization bugs.

> Synchronization issues around state transition
> ----------------------------------------------
>                 Key: HDFS-2693
>                 URL: https://issues.apache.org/jira/browse/HDFS-2693
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-2693.txt, hdfs-2693.txt, hdfs-2693.txt, hdfs-2693.txt
> Currently when the NN changes state, it does so without synchronization. In particular,
the state transition function does:
> (1) leave old state
> (2) change state variable
> (3) enter new state
> This means that the NN is marked as "active" before it has actually transitioned to active
mode and opened its edit logs. This gives a window where write transactions can come in and
the {{checkOperation}} allows them, but then they fail because the edit log is not yet opened.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message