hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2660) Turn off TestDFSOverAvroRpc
Date Mon, 12 Dec 2011 19:55:30 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167727#comment-13167727
] 

Doug Cutting commented on HDFS-2660:
------------------------------------

I'm confused.  HDFS-2647 broke TestDFSOverAvroRpc, so now the fix is to disable the test?
 Things should pass tests before we commit them to trunk.  Rather than committing this patch
you should revert HDFS-2647 and commit it once it passes tests.

We should either maintain the Avro RPC code or remove it if we don't intend to maintain it.
 This is the third time this has happened recently, where code is committed even though it
causes TestDFSOverAvroRpc to start failing.

If you don't want to maintain the Avro RPC code and intend to break it, then I suggest you
file an issue to remove it and then make HDFS-2647 depend on that issue.  Or else fix TestDFSOverAvroRpc
in HDFS-2647.


                
> Turn off TestDFSOverAvroRpc
> ---------------------------
>
>                 Key: HDFS-2660
>                 URL: https://issues.apache.org/jira/browse/HDFS-2660
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2660.txt
>
>
> With HDFS-2647, protobuf based RPCs are enabled for some of the protocol. With this,
Avro RPC based protocol is not working. Avro based RPC needs to be turned on similar to how
protobuf based RPCs are done. Until such a time, I propose turning off the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message