Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6C837E54 for ; Fri, 11 Nov 2011 12:33:13 +0000 (UTC) Received: (qmail 24380 invoked by uid 500); 11 Nov 2011 12:33:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24309 invoked by uid 500); 11 Nov 2011 12:33:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24295 invoked by uid 99); 11 Nov 2011 12:33:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Nov 2011 12:33:13 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Nov 2011 12:33:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6A9E44DB64 for ; Fri, 11 Nov 2011 12:32:52 +0000 (UTC) Date: Fri, 11 Nov 2011 12:32:52 +0000 (UTC) From: "Harsh J (Updated) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <930525615.20941.1321014772438.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <806323341.16371.1320892671611.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HDFS-2547: -------------------------- Attachment: HDFS-2547.patch New patch that changes comments and fixes a typo. > ReplicationTargetChooser has incorrect block placement comments > --------------------------------------------------------------- > > Key: HDFS-2547 > URL: https://issues.apache.org/jira/browse/HDFS-2547 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.20.1 > Reporter: Harsh J > Assignee: Harsh J > Priority: Trivial > Fix For: 0.20.206.0 > > Attachments: HDFS-2547.patch, HDFS-2547.patch > > > {code} > /** The class is responsible for choosing the desired number of targets > * for placing block replicas. > * The replica placement strategy is that if the writer is on a datanode, > * the 1st replica is placed on the local machine, > * otherwise a random datanode. The 2nd replica is placed on a datanode > * that is on a different rack. The 3rd replica is placed on a datanode > * which is on the same rack as the **first replca**. > */ > {code} > That should read "second replica". The test cases confirm that this is the behavior, as well as the docs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira