Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 1 Nov 2011 17:25:33 +0000 (UTC)
From: "Eli Collins (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <695954772.46577.1320168333531.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1531497865.44806.1320130232367.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2526)
 (Client)NamenodeProtocolTranslatorR23 do not need to keep a reference to
 rpcProxyWithoutRetry
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141359#comment-13141359 ] 

Eli Collins commented on HDFS-2526:
-----------------------------------

+1 looks great. Test failures are unrelated.
                
> (Client)NamenodeProtocolTranslatorR23 do not need to keep a reference to rpcProxyWithoutRetry
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2526
>                 URL: https://issues.apache.org/jira/browse/HDFS-2526
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client, name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-2526.patch
>
>
> HADOOP-7607 made it so that when wrapping an RPC proxy with another proxy, one need not hold on to the underlying proxy object to release resources on close. Both {{ClientNamenodeProtocolTranslatorR23}} and {{NamenodeProtocolTranslatorR23}} do not take advantage of this fact. They both also unnecessarily declare {{getProxyWithoutRetry}} methods which are unused.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira