Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 28 Nov 2011 19:31:42 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <204159673.19109.1322508702118.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <218954647.16434.1322462081209.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2596) TestDirectoryScanner doesn't test
 parallel scans
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158671#comment-13158671 ] 

Hadoop QA commented on HDFS-2596:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505298/hdfs-2596-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1611//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1611//console

This message is automatically generated.
                
> TestDirectoryScanner doesn't test parallel scans
> ------------------------------------------------
>
>                 Key: HDFS-2596
>                 URL: https://issues.apache.org/jira/browse/HDFS-2596
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, test
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2596-1.patch
>
>
> The code from HDFS-854 below doesn't run the test with parallel scanning. They probably intended "parallelism < 3".
> {code}
> +  public void testDirectoryScanner() throws Exception {
> +    // Run the test with and without parallel scanning
> +    for (int parallelism = 1; parallelism < 2; parallelism++) {
> +      runTest(parallelism);
> +    }
> +  }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira